Skip to content

Conversation

@devin-ai-integration
Copy link

chore: Migrate Java version from 8 to 11

Summary

Updates the banking application's Java version configuration from Java 8 to Java 11 as part of the larger migration plan. This PR includes:

  • Maven configuration: Updated pom.xml to set java.version property from 1.8 to 11
  • Documentation updates: Updated both README files to specify Java 11 as the minimum requirement
  • IDE setup documentation: Added comprehensive setup instructions for Eclipse/STS, IntelliJ IDEA, and VS Code to help developers configure their environments for Java 11

The application continues to use Spring Boot 2.1.4.RELEASE with existing dependencies.

Review & Testing Checklist for Human

⚠️ High Priority - The following items require careful verification as local testing was blocked by environment constraints:

  • Verify compilation: Run mvn clean compile to ensure the project compiles successfully with Java 11
  • Verify Spring Boot compatibility: Confirm Spring Boot 2.1.4.RELEASE works correctly with Java 11 (released April 2019, Java 11 support should be present)
  • Test application startup: Run mvn spring-boot:run and verify the application starts without errors on port 8989
  • Test core functionality: Access Swagger UI at http://localhost:8989/bank-api/swagger-ui.html and verify REST endpoints work
  • Verify H2 console: Access H2 database console at http://localhost:8989/bank-api/h2-console/ and ensure database connectivity works

Test Plan Recommendation

  1. Run full Maven lifecycle: mvn clean compile test package
  2. Start the application and perform basic banking operations via Swagger UI
  3. Create a customer, add an account, perform a transfer transaction
  4. Verify transaction history and account balances are correct

Notes

  • Environment Issue: Local testing failed with "invalid target release: 11" due to Java 8 environment configuration
  • Dependencies: All Maven dependencies (Lombok, Swagger, H2, Spring Security) should be compatible with Java 11, but runtime verification is needed
  • IDE Documentation: Added detailed setup instructions for three major IDEs to help team transition smoothly

Link to Devin run: https://app.devin.ai/sessions/838286fcbee74e08ba74adb2513ba908
Requested by: Jaime Mizrachi (@jaime-leo)

- Update pom.xml java.version property from 1.8 to 11
- Update README.md to specify Java 11 requirement
- Update README_NEW.md to specify Java 11 requirement
- Add comprehensive IDE configuration documentation for Java 11 in CONTRIBUTING.md
  - Eclipse/Spring Tool Suite setup instructions
  - IntelliJ IDEA setup instructions
  - Visual Studio Code setup instructions
  - Verification steps for all IDEs

Part of Java 8 to Java 11 migration plan for banking application.

Co-Authored-By: Jaime Mizrachi <[email protected]>
@devin-ai-integration
Copy link
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

- Split long line on line 15 to comply with 100 char limit
- Wrap bare URLs in angle brackets (lines 39, 131)
- Add blank line before JSON code block (line 97)

Fixes CI lint-and-links check failures

Co-Authored-By: Jaime Mizrachi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant